search

waddou / libass

Automatically exported from code.google.com/p/libass
1 stars 0 forks source link

No-break thin space regression #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
No-break thin space character (U+202F) is ignored (as if there is no space). 
This is a regression, as it was rendered correctly in v0.9.13. Bug seems to 
have appeared in v0.10.0.

Please see attached screenshots using libass v0.9.13 and v0.10.0. Test UTF-8 
ASS file also attached.

No-break thin space is required for proper French punctuation.

Original issue reported on code.google.com by hiddensp...@gmail.com on 4 May 2012 at 1:51

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I decided to have a look at the code, and I think I might have found the 
culprit. The thin no-break space character (U+202F) was skipped. I don’t know 
if that was a typo or if there was any reason to it. Anyway, U+202F is 
definitely a space character, not a control character. Please see the attached 
patch.

With this modification, thin no-break space is correctly displayed again.

Original comment by hiddensp...@gmail.com on 17 May 2012 at 10:30

Attachments:

GoogleCodeExporter commented 8 years ago 
That's definitely a typo or mistake, yes. I have no idea how that slipped in! 
I'll see what's up with #55 and commit a fix after that.

Original comment by g...@chown.ath.cx on 18 May 2012 at 11:07

GoogleCodeExporter commented 8 years ago 
This is fixed with revision de4092.

Original comment by g...@chown.ath.cx on 19 May 2012 at 3:07