search

waddou / libass

Automatically exported from code.google.com/p/libass
1 stars 0 forks source link

Make dependency on FriBidi optional #82

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Attached patch Make dependency on FriBidi optional. Patch based on 
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2011-December/069597.html

Original issue reported on code.google.com by mihail.z...@gmail.com on 4 Jan 2013 at 2:15

Attachments:

GoogleCodeExporter commented 8 years ago 
The dependency is intentional, to make sure libass always supports basic 
bidirectional rendering. Do you have any problems with getting FriBidi to work? 
It's very portable and should run almost anywhere, certainly everywhere libass 
runs.

Original comment by g...@chown.ath.cx on 4 Jan 2013 at 2:26

GoogleCodeExporter commented 8 years ago 
I don't need  bidirectional rendering as well as many other people, why I 
should install FriBidi to my system? Have less mandatory dependency simplify 
update packages. For small live-usb distro it also saves space and memory. If 
we can do it optionally - why not?

Original comment by mihail.z...@gmail.com on 4 Jan 2013 at 3:37

GoogleCodeExporter commented 8 years ago 
> Have less mandatory dependency simplify update packages. For small live-usb 
distro it also saves space and memory.

I don't buy this. Fribidi is a small library, less than 100 KB compiled. It 
does not have any notable dependencies itself, and does not need to be updated 
often. If you cannot manage this, that is your fault.

Why not? Because every toggle and optional dependency means more configurations 
that need to be tested, more ifdef mess and more possible problems in general.

Original comment by g...@chown.ath.cx on 4 Jan 2013 at 4:21