search

wadealexc / fevmate

Solidity libraries for use on the Filecoin EVM
MIT License
12 stars 6 forks source link

WFIL token doesn't support permit #9

Open bahadylbekov opened 1 year ago

bahadylbekov commented 1 year ago

Hi, I've noticed that WFIL implementation doesn't support permits which makes it harder to use with Multicall-based routers. Any thoughts on replacing the ERC20 token inside with the solmate version?

wadealexc commented 1 year ago

Copying over from Slack -

I didn’t add permit because signatures aren’t as easy in FEVM. Wanted to consider how to support BLS and SECPK actors, since they’re also supported by the rest of the WFIL implementation.

It wasn’t an easy thing to add and testing is already tough for FEVM stuff, so it got left out in favor of building something as simple and solid as possible.

Could be something we implement in a future version, though!

Also note, this library is based on solmate. There's a reason I didn't port it over 1:1 - FEVM needs some additional handling for non-EVM addresses in EVM contexts. You can read the README for more details on that!