search

wadefagen / Teachers-Ranked-As-Excellent-UIUC

A collection of all "Teachers Ranked as Excellent" at UIUC from Fall 1993 to present.
6 stars 0 forks source link

Some `fname`s not first initials #3

Open coatless opened 6 years ago

coatless commented 6 years ago

Didn't catch this when I was initially playing with the data... But, some of the fname entries contain full names or more than 1 initial.

Quick glance:

# Grab data
download.file("https://raw.githubusercontent.com/wadefagen/Teachers-Ranked-As-Excellent-UIUC/master/TRE-UIUC-AllYears.csv", "TRE-UIUC-AllYears.csv")

# Read data in
tre_data = read.csv("TRE-UIUC-AllYears.csv", na.strings = c("?", "NA"), 
                    stringsAsFactors = FALSE)

# Preview a couple of observations that have fnames greater than 1 character width
head(tre_data[nchar(tre_data$fname) > 1,])
#       term                                       unit    lname         fname       role     ranking course
# 1161  fa2003 NATURAL RESOURCES & ENVIRONMENTAL SCIENCES   REBEIZ            C. Instructor Outstanding    367
# 7199  sp1996                                ADVERTISING  ROTZOLL        K    O Instructor   Excellent    393
# 19782 fa2006                                    PHYSICS    SMITH          A.D.         TA Outstanding    213
# 19783 fa2006                                    PHYSICS    SMITH          A.D.         TA Outstanding    214
# 19784 fa2006                                    PHYSICS    SMITH          A.Z.         TA   Excellent    212
# 20257 fa2007          AGRICULTURAL & CONSUMER ECONOMICS DURGUNER          SEDA         TA   Excellent    100
# 20258 fa2007          AGRICULTURAL & CONSUMER ECONOMICS DURGUNER          SENA         TA   Excellent    100
# 22873 fa2008                                    FINANCE DURGUNER          SEDA         TA Outstanding    221
# 22874 fa2008                                    FINANCE DURGUNER          SENA         TA Outstanding    221
# 23103 fa2008                        INTEGRATIVE BIOLOGY  DOUGLAS       MARLISE Instructor   Excellent    368
# 23104 fa2008                        INTEGRATIVE BIOLOGY  DOUGLAS       MICHAEL Instructor   Excellent    368

I'm pretty sure that fname needs to be tweaked here:

https://github.com/wadefagen/Teachers-Ranked-As-Excellent-UIUC/blob/125cc073d1d9a1b672bbf10327cb79eaa672e655/script/index.js#L121-L125

wadefagen commented 6 years ago

Great catch!

I believe the Fall 2017 data will be out in the next week or two. I'll dig into this and adding the Fall 2017 data into the dataset as soon as CTE releases the Fall TRE.