Remove stroke from bg rect

wader / ansisvg

Convert ANSI to SVG

MIT License

89 stars 9 forks source link

Remove stroke from bg rect #18

Closed patrislav1 closed 10 months ago

patrislav1 commented 10 months ago

The 1px stroke around the background rects exceeds the area supposed to be filled. Remove stroke so only the area defined by CharacterBoxSize is filled.

wader commented 10 months ago

Good catch, wonder why i was there hmm. Can the stroke-width be removed also?

btw you can update test output with go test ./… -update verify it looks ok then just git add them

wader commented 10 months ago

Nope probably can't remove, default value is 1px it seems

wader commented 10 months ago

Looks ok locally so i'll merge and updated the tests