wader / ansisvg

Convert ANSI to SVG
MIT License
89 stars 9 forks source link

Use CSS style for colors #33

Closed patrislav1 closed 10 months ago

patrislav1 commented 10 months ago

This PR is trying to use CSS styles for recurring style attributes (primarily for colors) to 1) reduce SVG size and make it more readable and 2) make colors easily adjustable in the SVG code for all characters that use it. This is WIP, I thought I could get away with using a single set of color styles for both background and foreground, but turns out that setting the stroke color affect the text rendering.

wader commented 10 months ago

Nice, good idea. When messing around with these thing you really appreciate having good tests :) so please add more if you like

wader commented 10 months ago

Some possible things to look into:

But as you also mentioned i think we should probably stay away from too crazy tricks to keep the svg easily editable. For
example i wonder if the background could be a small embedded png that is stretched? :)

patrislav1 commented 10 months ago

I've improved it a bit, can you check again? (Not sure if this needs additional tests..?)

I can already think of ways to make the file more compact with more use of <g>, also probably stuff like bold and italic can be pulled out to a class style definition, making the SVG code even more compact.

should we do that in separate PRs or right here? (I'm fine with merging this already if you're satisfied)

wader commented 10 months ago

Output looks good, can merge if you want 👍 had some minor code comments but no biggies.

For new features, regressions or some tricky edge cases i usually try to add some kind of test

patrislav1 commented 10 months ago

:rocket: