search

wader / ansisvg

Convert ANSI to SVG
MIT License
89 stars 9 forks source link

Use getopt style short/long argument flags (without using getopt package) #34

Closed wader closed 9 months ago

wader commented 9 months ago

Alternative to #30 without using getopt package. One difference is that multiple short flags can't be combined ex: -ab instead of -a -b does not work.

wader commented 9 months ago

@patrislav1 less code but works a little bit differently for short flags

patrislav1 commented 9 months ago

don't have a strong opinion, I mean being able to combine flags is nice but it's not crucial and most of the flags require arguments anyway

wader commented 9 months ago

don't have a strong opinion, I mean being able to combine flags is nice but it's not crucial and most of the flags require arguments anyway

Mm same :) i usually try to be conservative about not using standard library.

But i should probably add some short flag tests at least... and at the same time maybe change the test to use .stdout?

BTW if you want i can add you as a collaborator so you can do more things yourself, i trust your judgement :)

patrislav1 commented 9 months ago

BTW if you want i can add you as a collaborator so you can do more things yourself, i trust your judgement :)

Thank you :smile: Yes it would make sense then I guess.