interp: Improve colors when using light background

wader / fq

jq for binary formats - tool, language and decoders for working with binary and text formats

Other

9.63k stars 221 forks source link

interp: Improve colors when using light background #781

Closed wader closed 9 months ago

wader commented 9 months ago

Related to #729

wader commented 9 months ago

@thushan hey! could you give this a spin in windows and see if colors looks ok in cmd and the new terminal thingy?

thushan commented 9 months ago

Windows Terminal test (built from master 5af117474114751d62da1da56ce731d46a39a295)

Dark

Light

vs v0.8.0:

Dark

Light

This is probably an extreme example because I have Windows Terminal + Starship + dark themes, so the light theme isn't properly configured, but alas this does fix it :)

wader commented 9 months ago

Thanks a lot! I should really get myself a windows dev env somehow, used to virtualized one but was slow pain to use.

Seems to look fine. A bit weird that neither before (brightwhite) or after (defaultgb+bold) the lightest white made any difference. Maybe a theme thing?