search

wader / fq

jq for binary formats - tool, language and decoders for working with binary and text formats
Other
9.74k stars 227 forks source link

PyRDP format #959

Open obilodeau opened 3 months ago

obilodeau commented 3 months ago

As discussed in https://github.com/GoSecure/fq-pyrdp/issues/1.

The new test case is 2.9MB. Let me know if this is still too big.

For project history see: https://github.com/GoSecure/fq-pyrdp/

This PR is done as part of GeekWeek 9.

wader commented 3 months ago

Thanks! did a quick review, will look more tomorrow.

The new test case is 2.9MB. Let me know if this is still too big.

Is fine i think. Just noticed that the wasm testdata i 42MB 😬

For project history see: https://github.com/GoSecure/fq-pyrdp/

Could be added to documentation if you like

This PR is done as part of GeekWeek 9.

🥳

wader commented 3 months ago

Hey, are ok with me pushing to your PR branch? i'm on vacation atm but when i'm back i might try massage this PR to look more like the rest of fq:s code

obilodeau commented 3 months ago

Let me do another pass today and tomorrow then it'll be your turn.

obilodeau commented 3 months ago

Made all required changes and fixed all CI linter errors. From my perspective, this is complete and useful.

Let me know if you want other changes.

wader commented 3 months ago

Made all required changes and fixed all CI linter errors. From my perspective, this is complete and useful.

Let me know if you want other changes.

Great thanks! will have look during the weekend or week. Will request you to review if i done any substantial changes, but i guess i will mostly just do some styling changes for consistency.

BTW i have been working on a prototype to allow runtime definition of decoders using kaitai. Would something like that have been useful in this case? maybe some other format specification language could be interesting? i've dumped some ideas in https://github.com/wader/fq/issues/627 if your intersted.

wader commented 3 months ago

Rebased on master, fix some code style stuff, less name stutter and made some flag gaps into unused fields