search

wader / static-ffmpeg

Multi-arch docker image with ffmpeg/ffprobe binaries built as hardened static PIE binaries with no external dependencies
https://hub.docker.com/r/mwader/static-ffmpeg/
MIT License
256 stars 62 forks source link

make libfdk-aac opt-in to avoid license issues #341

Closed grusell closed 11 months ago

wader commented 11 months ago

Thanks! i was thinking that maybe the CI PR build should build with --build-arg ENABLE_FDKAAC=1 to make sure it's not bit rotting?

wader commented 11 months ago

Maybe not a big deal but with this we will still always download/build fdkaac. I've done various experiments before to make all libs optional, and have a default to build al., But it's tricky do to in a way that you don't end up with ex frankenstein Dockerfile that is hard to have a overview of, i really like how clean and simple the current one is.

grusell commented 11 months ago

I agree it could make sense to build with libfdk-aac enabled in the CI to verify that that works. Do you want me to update this in the PR?

Yes, I thought it wasn't worth it to complicate things by making the actual build of the libfdk-aac opt-in, I assume it won't add much to the build time anyway.

wader commented 11 months ago

I agree it could make sense to build with libfdk-aac enabled in the CI to verify that that works. Do you want me to update this in the PR?

Yeap do that

Yes, I thought it wasn't worth it to complicate things by making the actual build of the libfdk-aac opt-in, I assume it won't add much to the build time anyway.

Agree, let's keep it simple for now and we can fix in later if something more generic is done

grusell commented 11 months ago

PR updated as discussed.

wader commented 11 months ago

Looks good. Ready to merge?

wader commented 11 months ago

Tack!