search

wader / static-ffmpeg

Multi-arch docker image with ffmpeg/ffprobe binaries built as hardened static PIE binaries with no external dependencies
https://hub.docker.com/r/mwader/static-ffmpeg/
MIT License
245 stars 60 forks source link

Add libjxl #389

Closed karuboniru closed 7 months ago

karuboniru commented 7 months ago

I decided to build libjxl in dockerfile instead of waiting the alpine fix. Since I noticed that alpine don't ship libhwy-static, and libhwy will be a dependency for libjxl. Which means even if we got working libjxl-static from them, still, it won't work for us.

Regarding the libjxl build here, I am doing some trick (namely the line --extra-libs="-lstdc++") to make the configuration process of ffmpeg happy. I don't know if this is the right option or I should be patching the .pc file shipped with libjxl instead.

wader commented 7 months ago

Hey! thanks for contributing!

I decided to build libjxl in dockerfile instead of waiting the alpine fix. Since I noticed that alpine don't ship libhwy-static, and libhwy will be a dependency for libjxl. Which means even if we got working libjxl-static from them, still, it won't work for us.

Ok! fine with me. Know if there is some reason alpine don't ship a libhwy-static? i've reported a few missing -static packages before, seems it usually just that someone forgot.

Regarding the libjxl build here, I am doing some trick (namely the line --extra-libs="-lstdc++") to make the configuration process of ffmpeg happy. I don't know if this is the right option or I should be patching the .pc file shipped with libjxl instead.

Maybe can patch the .pc as i already do that for libvmaf atm? mostly to keep the hacks for each library close to the rest of the build for that library... think it makes sense

wader commented 7 months ago

LGMT will merge once CI is happy unless you want to add something more? Thanks a lot!