wader / static-ffmpeg

Multi-arch docker image with ffmpeg/ffprobe binaries built as hardened static PIE binaries with no external dependencies
https://hub.docker.com/r/mwader/static-ffmpeg/
MIT License
233 stars 56 forks source link

Added fontconfig example for custom directory mount #476

Closed ToshY closed 2 weeks ago

ToshY commented 2 weeks ago

Fixes #471

ToshY commented 2 weeks ago

Hey @wader πŸ‘‹

I've created a draft PR for the issue we were discussing. Can you take a look at this? Feel free to change whatever needs to be changed (English is not my native language).

wader commented 2 weeks ago

Hey @wader πŸ‘‹

I've created a draft PR for the issue we were discussing. Can you take a look at this? Feel free to change whatever needs to be changed (English is not my native language).

Great πŸ‘ had some comments, mostly want to understand how fontconfig works and what's the minimal thing needed.

Not native english either πŸ‡ΈπŸ‡ͺ and in my judgement your english is excellent.

ToshY commented 2 weeks ago

Ok to merge for me, ok with you? can always do more PRs later also.

That's fine by me.

The README is getting a bit long, i wonder if it should be split up in some point? πŸ€” also thought about maybe using the wiki for some things?

Hmm yes it's getting a bit crowded. It's up to you. Do you want to move some stuff now or later?

[!TIP] Maybe use squidfunk/mkdocs-material instead of Github Wiki.

wader commented 2 weeks ago

Ok to merge for me, ok with you? can always do more PRs later also.

That's fine by me.

πŸ‘

The README is getting a bit long, i wonder if it should be split up in some point? πŸ€” also thought about maybe using the wiki for some things?

Hmm yes it's getting a bit crowded. It's up to you. Do you want to move some stuff now or later?

Something for later i think, lets get this merged

Tip

Maybe use squidfunk/mkdocs-material instead of Github Wiki.

Interesting, thanks!

wader commented 2 weeks ago

πŸ₯³