search

waderyan / vscode-gitblame

Visual Studio Code Extension - See Git Blame info in status bar.
https://marketplace.visualstudio.com/items/waderyan.gitblame
MIT License
71 stars 50 forks source link

Ignore whitespace changes #15

Open carloscz opened 8 years ago

carloscz commented 8 years ago

Hi, it would be great if whitespace changes could be ignored. I have prepared change of git-blame enabling this behaviour, but original author of NPM package seems to be a bit inactive.

Would You consider moving to another package for this feature?

waderyan commented 8 years ago

Interesting idea. Why do you want to ignore whitespace? I don't find it especially valuable to see blame on whitespace, but it isn't a distraction.

carloscz commented 8 years ago

yeah, but current version of git-blame seems to take whitespace changes into consideration. So if anyone replaces tabs for spaces in the entire file, vscode-gitblame marks him as author of every line :)

waderyan commented 8 years ago

Ah that is a good point. Want to do a PR? 😄

carloscz commented 8 years ago

I did for git-blame referenced by Your extension, but with no response from original developer :( I think I will wait few days more and then publish my extended module to NPM. Then it could be worked into this by PR

carloscz commented 7 years ago

Sorry for HUGE delay :( created pull request today https://github.com/waderyan/vscode-gitblame/pull/24 :)