search

wadewegner / deploy-to-sfdx

An open-source and community-driven tool for one-click Salesforce DX deployments from public repositories to Scratch Orgs
https://deploy-to-sfdx.com
Apache License 2.0
98 stars 22 forks source link

Oops I did it again!! #37

Open joehuffnagle opened 6 years ago

joehuffnagle commented 6 years ago

GUID: c210de13-72d2-14c0-ad3a-8dab7338a390 Cloning into '.'...remote: Not Found fatal: repository 'https://github.com/watson-developer-cloud/salesforce-sdk/blob/develop/README.md/' not found

2) GUID: c210de13-72d2-14c0-ad3a-8dab7338a390 Cloning into '.'...remote: Not Found fatal: repository 'https://github.com/watson-developer-cloud/salesforce-sdk/blob/develop/README.md/' not found 1) No .salesforcedx.yaml found in repository. Using defaults.

FabienTaillon commented 6 years ago

I think it’s the same as issue #31. Deploy to SFDX button either takes a « template » url attribute to the repo, or takes the repo it’s in.

Except that this will work only if the url you’re at when clicking on the button is the root url. Here you’ve likely opened the readme file itself and clicked on the button from there, this the current url is “incorrect”.

Try good no to the repo root url (https://github.com/watson-developer-cloud/salesforce-sdk) and click to the button directly from there, it should work.

There is something that needs to be changed here anyway to avoid these kind of issues.

afawcett commented 6 years ago

Its likely something between how it determines the repo automatically (via referrer) and the GitHub API, some parsing of the URL likely is needed. Will take a look. 👍