search

wadewegner / deploy-to-sfdx

An open-source and community-driven tool for one-click Salesforce DX deployments from public repositories to Scratch Orgs
https://deploy-to-sfdx.com
Apache License 2.0
98 stars 22 forks source link

Failure to deploy if referrer doesn't point directly to the repo #9

Closed wadewegner closed 6 years ago

wadewegner commented 7 years ago

Repro:

1) Open URL: https://github.com/wadewegner/sfdx-simple/blob/master/README.md 2) Click "Deploy to SFDX" 3) Login. 4) Deploy.

image

Notice the /blob/master/README.md.

Error:

image

Two options:

1) Remove extra info immediately before logging in. 2) Update the deployment script to find the repo instead of using the whole referrer.

I'd prefer #1. Makes it less confusing.

wadewegner commented 6 years ago

Doesn't feel like I should hardcode a instead I'll throw the error better