search

wadewegner / salesforce-cli-zsh-completion

A Zsh completion file for the Salesforce CLI (and script for updating it)
Apache License 2.0
90 stars 24 forks source link

add to oh-my-zsh #6

Open ChuckJonas opened 6 years ago

ChuckJonas commented 6 years ago

This is awesome. Not sure what it takes to get it added, but I'd love to see this included in the default OhMyZsh plugin list

https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins

catalandres commented 6 years ago

Adding it to zsh-users/zsh-completions would make it available in antigen, oh-my-zsh and prezto.

See their contribution guidelines.

@wadewegner ...would you consider adding _sfdx to the project?

wadewegner commented 6 years ago

I'm pretty sure I sent PRs to both of these and they were never accepted.

wadewegner commented 6 years ago

oh-my-zsh: https://github.com/robbyrussell/oh-my-zsh/pull/6540

zsh-completions: https://github.com/zsh-users/zsh-completions/pull/550

If you have thoughts on how to get them to accept, I'd be happy to update and send along.

tekamoment commented 5 years ago

@wadewegner Hi! Just checked on the status of these.zsh-completions has accepted your pull request. oh-my-zsh has two comments before accepting your pull request.

rsoesemann commented 5 years ago

@wadewegner did you ever get this finished?

nchursin commented 5 years ago

It was merged, but it actually doesn't seem working. I tried adding the plugin to my .zshrc, but no completions appeared

daeschwed commented 5 years ago

@nchursin try resetting completions, that did the trick for me:

rm ~/.zcompdump*
compinit
unixorn commented 5 years ago

I'm adding this repo to the awesome-zsh-plugins in https://github.com/unixorn/awesome-zsh-plugins/pull/828.

As far as I can tell, upstream oh-my-zsh isn't taking new plugins or themes for the main repo. Standalone git repositories like this make it much easier for people using other frameworks though, so overall that feels like a win.