wadobo / socializa-api

Socializa is an interactive game for play it out of home
GNU Affero General Public License v3.0
1 stars 0 forks source link

Implemented: ContentTypes API call #24

Closed rarellano closed 5 years ago

Virako commented 5 years ago

The PR is correct. The tests are required.

rarellano commented 5 years ago

Done!

danigm commented 5 years ago

Just a note about commit messages, we should try to use good commit messages:

In this case you're using past instead of imperative to describe the commit:

https://chris.beams.io/posts/git-commit/#imperative

From the original blog post:

So when you write your commit messages in the imperative, you’re following Git’s own built-in conventions. For example:

Refactor subsystem X for readability
Update getting started documentation
Remove deprecated methods
Release version 1.0.0

Writing this way can be a little awkward at first. We’re more used to speaking in the indicative mood, which is all about reporting facts. That’s why commit messages often end up reading like this:

Fixed bug with Y
Changing behavior of X

And sometimes commit messages get written as a description of their contents:

More fixes for broken stuff
Sweet new API methods

To remove any confusion, here’s a simple rule to get it right every time.

A properly formed Git commit subject line should always be able to complete the following sentence:

If applied, this commit will YOUR SUBJECT HERE