Closed l-k- closed 11 months ago
I think tests are failing because of the correction to the temperature. I fixed this in the other branch in this commit: 5cae79f
oh, got it, thank you!
Merging #37 (215d807) into main (8248608) will decrease coverage by
0.78%
. Report is 5 commits behind head on main. The diff coverage is86.13%
.:exclamation: Current head 215d807 differs from pull request most recent head d9312f9. Consider uploading reports for the commit d9312f9 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 86.49% 85.71% -0.78%
==========================================
Files 9 9
Lines 955 924 -31
==========================================
- Hits 826 792 -34
- Misses 129 132 +3
Files Changed | Coverage Δ | |
---|---|---|
R/readGENEActiv.R | 100.00% <ø> (ø) |
|
src/GENEActivReader.cpp | 87.91% <ø> (-7.51%) |
:arrow_down: |
R/readAxivity.R | 86.19% <86.00%> (+1.31%) |
:arrow_up: |
R/readGenea.R | 84.50% <100.00%> (ø) |
@l-k- PR looks good, I have made a separate PR #39 into this PR #37 to address a minor issue, to update the changelog, and to add you as package contributor: https://github.com/wadpac/GGIRread/pull/39
Let me know if you are happy with those changes and then I think we can merge everything to main.
@vincentvanhees I think I'm done with this, ready to merge. Thank you for catching the two bugs!
I think tests are failing because of the correction to the temperature. I fixed this in the other branch in this commit: https://github.com/wadpac/GGIRread/commit/5cae79f3f415a48ea9752b9c352aa365bc338a1a