search

waf / CSharpRepl

A command line C# REPL with syntax highlighting – explore the language, libraries and nuget packages interactively.
https://fuqua.io/CSharpRepl/
Mozilla Public License 2.0
2.95k stars 112 forks source link

Move 'multiple nuspec' detection logic earlier #278

Closed waf closed 1 year ago

waf commented 1 year ago

We currently have the following workaround for multiple nuspecs that differ only by case:

https://github.com/waf/CSharpRepl/blob/35cc2b7ea54153894021d6d7e44285a71de391ac/CSharpRepl.Services/Nuget/NugetPackageInstaller.cs#L288-L294

Not totally sure under what circumstances a package can get into this state. However, in #259 we're currently seeing it when we're trying to read a package's supported frameworks, so we need to move this check earlier to handle it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #278 (35cc2b7) into main (f3a9741) will not change coverage. The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #278   +/-   ##
=====================================
  Coverage   77.5%   77.5%           
=====================================
  Files         81      81           
  Lines       5478    5478           
  Branches     721     721           
=====================================
  Hits        4248    4248           
  Misses       965     965           
  Partials     265     265
Impacted Files Coverage Δ
CSharpRepl.Services/Nuget/NugetPackageInstaller.cs 88.3% <100.0%> (ø)