waf / CSharpRepl

A command line C# REPL with syntax highlighting – explore the language, libraries and nuget packages interactively.
https://fuqua.io/CSharpRepl/
Mozilla Public License 2.0
2.95k stars 112 forks source link

Custom culture #296

Closed Keyros closed 1 year ago

Keyros commented 1 year ago

Fix #293 #241 Add culture support for MSDN documentation links

Included an option for users to specify their preferred culture for the MSDN documentation links

Now we can define custom culture at config.rsp file

waf commented 1 year ago

Thanks for the PR! From a quick look, it looks good. I'll review this and play around with it later this week.

Keyros commented 1 year ago

Thanks for the PR! From a quick look, it looks good. I'll review this and play around with it later this week.

Hi, is there any news on the pull request?

Keyros commented 1 year ago

Just some minor feedback. Thanks for this! Happy to merge this when the PR is updated and I'll get a new release spun out for this feature.

Apologies for taking a long time for getting this reviewed. I'm in the middle of wedding planning which leaves surprisingly little time for hacking on C# :)

@waf Congratulations!!!

Сomments were resolved, now CultureNotFoundException is thrown

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (af2ac23) 0.0% compared to head (c4d7f14) 77.5%. Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ======================================= + Coverage 0.0% 77.5% +77.5% ======================================= Files 83 83 Lines 5573 5584 +11 Branches 733 736 +3 ======================================= + Hits 0 4328 +4328 + Misses 5573 988 -4585 - Partials 0 268 +268 ``` | [Files](https://app.codecov.io/gh/waf/CSharpRepl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Fuqua) | Coverage Δ | | |---|---|---| | [CSharpRepl.Services/Configuration.cs](https://app.codecov.io/gh/waf/CSharpRepl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Fuqua#diff-Q1NoYXJwUmVwbC5TZXJ2aWNlcy9Db25maWd1cmF0aW9uLmNz) | `81.8% <100.0%> (+81.8%)` | :arrow_up: | | [CSharpRepl/CommandLine.cs](https://app.codecov.io/gh/waf/CSharpRepl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Fuqua#diff-Q1NoYXJwUmVwbC9Db21tYW5kTGluZS5jcw==) | `94.6% <100.0%> (+94.6%)` | :arrow_up: | | [CSharpRepl/CSharpReplPromptCallbacks.cs](https://app.codecov.io/gh/waf/CSharpRepl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Fuqua#diff-Q1NoYXJwUmVwbC9DU2hhcnBSZXBsUHJvbXB0Q2FsbGJhY2tzLmNz) | `80.8% <50.0%> (+80.8%)` | :arrow_up: | ... and [78 files with indirect coverage changes](https://app.codecov.io/gh/waf/CSharpRepl/pull/296/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Fuqua)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.