search

waf / CSharpRepl

A command line C# REPL with syntax highlighting – explore the language, libraries and nuget packages interactively.
https://fuqua.io/CSharpRepl/
Mozilla Public License 2.0
2.76k stars 106 forks source link

Provide a way to configure how many collection/list items should be displayed #377

Open mrlucmorin opened 1 month ago

mrlucmorin commented 1 month ago

Feature Description

At the moment, when displaying an IEnumerable, the number of items displayed depends on the screen size.

Having the possibility to configure this through a config file would facilitate inspecting more items, no matter how "high" the window is.

https://github.com/waf/CSharpRepl/discussions/376

Thanks

mrlucmorin commented 1 month ago

I'd be interested in trying to implement this functionality myself. Do you accept pull requests from non-collaborator users?

Do you have an "architecture" document or some other documentation describing the configuration file sub-system? From what I can see, this would impact multiple source files, and I'd like to make sure not to miss anything. For example, there are hard-coded strings, such as the "help" string, that would be impacted.

Thanks

mrlucmorin commented 1 month ago

I just saw the smaller prints about contributing guidelines. I'll go through the ARCHITECTURE.md file and make sure I grok it before starting work.

I'll circle back here if I decide to undertake anything.

waf commented 1 month ago

Hi, we'd be happy to accept a contribution for this. Thanks! Just need to make sure we have some sensible behavior when the IEnumerable does not terminate (or has millions of items). e.g.:

image

Also of interest to you might be the "Enter" vs "Ctrl+Enter" behavior -- the latter shows more elements than the former.