search

wafaahamdy / moodle-tool_resetpasswords

A Moodle Plugin for bulk reset password
Other
0 stars 1 forks source link

missing privacy api #8

Open danmarsden opened 7 months ago

danmarsden commented 7 months ago

Moodle uses a privacy API for GDPR compliance to allow plugins to specify how they deal with user data. Your plugin doesn't appear to store any user data so you should be able to implement the simple null provider class.

Sites that use continuous integration processes will not be able to use your plugin because Moodle runs unit tests which check to see if all extra plugins include the privacy class.

More information on the privacy class is here: https://moodledev.io/docs/apis/subsystems/privacy

danmarsden commented 7 months ago

note this is not a blocker for plugins db approval.

wafaahamdy commented 6 months ago

Thanks for the feedback.

I added the privacy file under classes folder https://github.com/wafaahamdy/moodle-tool_resetpasswords/blob/approval_issues/classes/privacy/provider.php

roland04 commented 6 months ago

Hi @wafaahamdy! Taking a look at the provider, I think you also need to add the namespace there namespace tool_resetpasswords\privacy;

Also the DocBlock in https://github.com/wafaahamdy/moodle-tool_resetpasswords/blob/main/classes/privacy/provider.php#L18 should be something like: "Privacy Subsystem for tool_resetpasswords implementing null_provider."

Hope it helps!

wafaahamdy commented 6 months ago

Thanks @roland04

I added the namespace as well as the Doc block