Refactor server routes to remove "dynamic" generation and utilize express.Router()

wafers / modulo

:bar_chart: :chart_with_upwards_trend: Enhanced Npm.js module search, ranking, data visualization & analytics.

http://modulo.heroku.com

9 stars 0 forks source link

Refactor server routes to remove "dynamic" generation and utilize express.Router() #251

Closed WesTyler closed 8 years ago

voxlol commented 8 years ago

:( I knew that was a bad idea back in the day

WesTyler commented 8 years ago

@voxlol Haha, also we weren't taking advantage of express.router, which is more expressive and clear. Doing the auto-generation doesn't follow the .router method paradigm. :)

voxlol commented 8 years ago

haha yep. We did a lot of things incorrectly back at makersquare...I wish they had a lecture on best practices!

quikstrike commented 8 years ago

Solved in PR #253.