search

waffle-gl / waffle

A C library for selecting an OpenGL API and window system at runtime
https://waffle.freedesktop.org
BSD 2-Clause "Simplified" License
35 stars 16 forks source link

wflinfo on GBM creates core context when compat requested #1

Closed linyaa-kiwi closed 10 years ago

linyaa-kiwi commented 10 years ago

On Sat, Mar 01, 2014 at 09:05:07PM -0800, Jordan Justen wrote to waffle@freedesktop.org:

$ wflinfo -p gbm -a gl --profile=compat -V 3.2
Waffle platform: gbm
Waffle api: gl
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Haswell
OpenGL version string: 3.3 (Core Profile) Mesa 10.2.0-devel (git-c97763c)
OpenGL context flags: 0x0

This should fail to create a context, right? And, obviously, it shouldn't create a core profile, right?!

linyaa-kiwi commented 10 years ago

I posted an untested fix to my personal branch issues/1/fix-egl-compat-profile, exact commit at https://github.com/chadversary/waffle/commit/ba6e561. The patch is untested because I have access to no Linux computer this weekend.

@jljusten , if you validate the patch, I'll merge it.

linyaa-kiwi commented 10 years ago

@jljusten , I posted a new fix that is more obviously correct. I'll merge after you test it.

https://github.com/chadversary/waffle/commit/f58fb36e9f2d2c9e1d5522cf2a975bb759198510 https://github.com/chadversary/waffle/tree/issues/1/fix-egl-compat-profile-v02

linyaa-kiwi commented 10 years ago

Fixed by https://github.com/waffle-gl/waffle/commit/25fbef8350a5e22fec7aa5176a6ca74ebadf7c62