search

wafflesfm / batter

It makes Waffles.
Other
83 stars 18 forks source link

Update "music" app models #26

Closed senturio closed 11 years ago

senturio commented 11 years ago

Music app needs to have its models updated.

I'm thinking along the lines of: MusicUpload (extends Upload) - all the encoding specific metadata - has as its parent: Release (is a thing like InbetweenersTweener) - all the release specific metadata like date, etc. Master (extends TorrentGroup) - all the album/EP specific metadata.

This structure is similar to discogs, I believe, for consistency. It'd be a good idea to look at what metadata they can provide when considering model design.

derekleverenz commented 11 years ago

I'll take a look at this

derekleverenz commented 11 years ago

btw I don't have a ton of time so this will probably take me a week or so, just to find a time to do it. So if anyone else wants to do it go ahead.

jzelinskie commented 11 years ago

The Release models need some kind of solution for Editions. This might be as simple as a textfield for edition but that leaves you something like this: Capture And not something like this: Capture

jzelinskie commented 11 years ago

I brought up on IRC that I have no idea what a "ArtistType" is. @elgruntox responded that it would house a value like "RnB Artist" or "Rap Artist". We ultimately agreed on IRC that tags were far more efficient than this. When I thought about it, an Artist's tags could simply be the combination of the tags of all their releases. Using this logic, we could completely eliminate the ArtistType model.

derekleverenz commented 11 years ago

I think artists should have independent tags, allowing for more flexibility and the ability to add tags that may be associated with one release that isn't in the system, though having releases automatically contribute tags to artists isn't a bad idea. I can see that potentially being incorrect though, esp in the case of multi-artist releases. I think its simpler to just replace the artist type field with a tags field.

Ell commented 11 years ago

This still needs work even after the latest pull. Per discussion we still don't have any sort of Master / Release implemented correctly and MusicUpload needs to FK Upload instead of Torrent

derekleverenz commented 11 years ago

this is done right? @ell can we close this?

edgewyn commented 11 years ago

I'm not sure how this differs from #15, but PR #50 should fulfill the requirements of this issue. Closing.