wafo-project / pywafo

Wave Analysis for Fatigue and Oceanography
http://www.maths.lth.se/matstat/wafo/
Other
94 stars 42 forks source link

Drop the copied modules from scipy #11

Open ocefpaf opened 9 years ago

ocefpaf commented 9 years ago

... and make scipy a dependency.

This will make it easier to manage packaging and versioning.

davidovitch commented 9 years ago

Thanks for taking an interest in pyWAFO. There are several things that have to be fixed regarding the installation and packaging:

I see you made some changes in the scipy branch of your fork, feel free to send the changes as pull requests here.

ocefpaf commented 9 years ago

conda package (optional)

I create a conda package here. It is easier than wheels.

I see you made some changes in the scipy branch of your fork, feel free to send the changes as pull requests here.

That branch is already a PR in #10.

davidovitch commented 9 years ago

Appoligies....I totally missed that PR.

ocefpaf commented 9 years ago

No problem. I try to always open an issue and a corresponding PR to that issue. Some people prefer that way for better bookkeeping.

davidovitch commented 9 years ago

I create a conda package here. It is easier than wheels.

Very nice indeed, thanks!

ocefpaf commented 9 years ago

Hi @davidovitch,

Just checking the reason for closing this. The developers have no interest in dropping the copied modules from scipy to a scipy import?

davidovitch commented 9 years ago

ok, my bad, I was a bit quick, I thought this was related to PR #10 (which has been merged), but now I understand it isn't. Re-opening.

ocefpaf commented 9 years ago

No problem. Once things stabilize and the tests are running I will try to implement this change.