add GitHub Actions testing

wafo-project / pywafo

Wave Analysis for Fatigue and Oceanography

http://www.maths.lth.se/matstat/wafo/

Other

94 stars 42 forks source link

add GitHub Actions testing #54

Closed ocefpaf closed 1 year ago

ocefpaf commented 2 years ago

This probably won't pass in the first iteration but let's see how far we can go trying to get the tests to run again.

davidovitch commented 2 years ago

I assume this PR will fix #52.

Looks pretty good to me but I don't have any experience with the Github/Travis build/test environment.

ocefpaf commented 2 years ago

I assume this PR will fix #52.

Yes. That fix is included.

Looks pretty good to me but I don't have any experience with the Github/Travis build/test environment.

I'll probably iterate more after this is merged this one is ready for a review and merge. Let me know if you want to add some extra comments on what this is doing.

ocefpaf commented 2 years ago

mpmath and pytest are also required to be able to run the tests (oops, didn't mean to review, just comment)

They are not removed. I moved them to a requirements-dev.txt which won't inject them as mandatory dependencies but will install them in a dev environment for running the tests.

morbult commented 2 years ago

My bad, missed that file.

I have no experience with Actions testing, or Travis for that matter, but it looks really neat. Out of curiosity, is this a separate approach to run testing than the existing .travis.yml? Is the plan to use Actions for building as well?

ocefpaf commented 2 years ago

I have no experience with Actions testing, or Travis for that matter, but it looks really neat. Out of curiosity, is this a separate approach to run testing than the existing .travis.yml? Is the plan to use Actions for building as well?

The plan is to remove Travis-CI and substitute it with GitHub Actions. Travis-CI was the state of the art for CI testing but since it was sold to another company the OSS service is really degraded and unreliable. GitHub Actions is faster, more flexible, and seems to be the new OSS standard.

ocefpaf commented 1 year ago

The CIs results can be viewed at https://github.com/ocefpaf/pywafo/actions/runs/3643452287/jobs/6151687789

Once merge they'll also run here on every PR. Things that are still missing but I cannot fix them at the moment:

[ ] Add Windows to the build matrix
[ ] Fix the macOS compilation on py>3.7
[ ] Fix the 1-2 failures that are happening on some of the matrix items test_to_t_pdf (all of them) and test_bk_regression_with_beta (some py version only)

This is as far as I can take this PR. I can investigate more the macOS builds and Windows compilation later but I'm clueless to the failures and if they are relevant or just bad expected results due to different scipy versions.

Gjacquenot commented 1 year ago

It would be nice to merge this pull request!

davidovitch commented 1 year ago

Thanks for the reminder. I will have a look this weekend and merge.