np.machar is depricated - Githubissues

wafo-project / pywafo

Wave Analysis for Fatigue and Oceanography

http://www.maths.lth.se/matstat/wafo/

Other

94 stars 42 forks source link

np.machar is depricated #61

Closed davidovitch closed 10 months ago

davidovitch commented 10 months ago

numpy.MaChar has been deprecated since numpy v1.22, and has been removed since v1.25 (see https://numpy.org/doc/1.25/release/1.25.0-notes.html and https://github.com/numpy/numpy/pull/22638). Not sure how to replace it yet, but one should be able to figure out based on the documentation:

numpy.finfo v1.22 https://numpy.org/doc/1.22/reference/generated/numpy.finfo.html#numpy.finfo
numpy.MachAr v1.22 https://numpy.org/doc/1.22/reference/generated/numpy.MachAr.html#numpy.MachAr
numpy.finfo v1.26 https://numpy.org/doc/1.26/reference/generated/numpy.finfo.html#numpy.finfo

np.finfo(float).machar.tiny should become np.finfo(float).tiny and np.finfo(float).machar.xmax np.finfo(float).max

davidovitch commented 10 months ago

was fixed by #57 and #62.