search

wagenaartje / stocks.js

:moneybag: stocks.js is an easy-to-use stock market API for Javascript
https://github.com/wagenaartje/stocks.js
MIT License
326 stars 69 forks source link

proposals #1

Open CVarisco opened 7 years ago

CVarisco commented 7 years ago

Hi @wagenaartje !

I like your idea 🙂 , and I started a little refactoring on my fork with your code style. But I propose a contribution guide to help other people to contribute. And it would be great if everything is written in ES6.

What do you think about it ? Have a nice day 🌮

wagenaartje commented 7 years ago

Love the improvement you made. It makes requests more generic, leaving some room open for future functions that will also make requests. I'll see the PR appear whenever :smile:

Great idea. I'll create a CONTRIBUTING.md soon that contains goals for the future as well as a simple guide on how to get started with contributing.

As for the style guide, i'd like to stick to Semi-StandardJS. I have never actually read through the ES6 coding style specifically, but i'll do that soon (and i'll include it in the contributing file).

Have a nice day too :pizza:

ghost commented 6 years ago

Is there any plan to add functionality for getting digital currency quotes, as alpha advantage offers this through their api?

I created a digitalCurrency method locally that takes an options object like all the other methods, but the problem comes with the _convertData function. It seems to not find the correct keys, and returns some funky data.

Is anything digital currency related something that might be in the future of stocks.js since crypto currency is related to investing like stocks on the NYSE?