search

wagerr / wagerr-electron-app

Wagerr Electron App is a cross-platform GUI for Wagerr.
MIT License
16 stars 17 forks source link

AppImage is missing a .DirIcon file #4

Open probonopd opened 5 years ago

probonopd commented 5 years ago

The AppImage is missing a .DirIcon file.

Possibly this is an electron-builder issue?

Reference: https://github.com/AppImage/appimage.github.io/pull/1648

Cryptarchist commented 5 years ago

@probonopd thanks for raising the issue. This sounded like it would be a simple fix, but alas, it is not.

We already have something like https://github.com/electron-userland/electron-builder/issues/2269#issuecomment-342168989 in place and that doesn't seem to work for us.

I will dig into this more during the week!

probonopd commented 5 years ago

A 256x256 px png file called .DirIcon needs to be in the root directory of the AppImage. I was hoping that electron-builder takes care of that, but apparently it does not. cc @azubieta

Cryptarchist commented 5 years ago

@probonopd thanks for raising the issue upstream, after investigation it does seem like the most appropriate place to resolve the bug rather than hacking something together here 😄