waggle-sensor / plugin_manager

Sensor plugins
3 stars 4 forks source link

Whitelisting Plugins #4

Closed seanshahkarami closed 7 years ago

seanshahkarami commented 8 years ago

In David's node, the envsense and alphasense plugins were not whitelisted and thus did not start once he'd connected the node.

Is this the expected default configuration or should this be changed? If we want to leave it as is, how do we decide on when to start a plugin once it's in the field. If we should change it, what if a device isn't connected?

geeklair commented 8 years ago

Two issues to tackle:

On Jul 14, 2016, at 11:16 AM, Sean Shahkarami notifications@github.com wrote:

In David's node, the envsense and alphasense plugins were not whitelisted and thus did not start once he'd connected the node.

Is this the expected default configuration or should this be changed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/waggle-sensor/plugin_manager/issues/4, or mute the thread https://github.com/notifications/unsubscribe/AMOVv4X_6C7j7TBTI49pWnHhAd0XX4cKks5qVmDSgaJpZM4JMmfv.

seanshahkarami commented 8 years ago

For the first part, my understanding now is that David's node just ended up in a weird state on Beehive, which he and Bill corrected manually. It sounds like it didn't have much, if anything, to do with those other services.

For the whitelisting point, Wolfgang and I talked about the autodetection idea some. It's not that we can't do it that way...it's just not a feature in the plugin manager as of now, so we'd have to add a thing to do that.

gemblerz commented 8 years ago

For now, system_base plugin (in branch-baseplugin) does 1) report system info to beehive, 2) auto-detect attached sensor boards and start the corresponding plugins, but not put the plugins in whitelist, and 3) report Wagman status every 30 seconds (we can discuss the reporting period, but it is just now 30 seconds).

To recap, after we merge the branch onto master, the question will be answered.

MuffinSpawn commented 7 years ago

The nodecontroller code has been merged, so this issue should be resolved. Closing...