search

wagoodman / dive

A tool for exploring each layer in a docker image
MIT License
47.42k stars 1.79k forks source link

Fix rendering for multi-line commands #443

Closed lutzky closed 1 year ago

lutzky commented 1 year ago

Heredocs can be used to create multi-line commands, which broke rendering.

Details about heredocs: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/

Before:

image

After:

image

(Example is adapted from https://fasterthanli.me/series/building-a-rust-service-with-nix/part-6)

mark2185 commented 1 year ago

Check out #399 as well, might prove useful.

lutzky commented 1 year ago

Thanks, I've left a comment on #399: https://github.com/wagoodman/dive/pull/399/files#r1166837287

I believe the run-static-analyses failure is unrelated to my change.

mark2185 commented 1 year ago

I believe the run-static-analyses failure is unrelated to my change.

I don't want to be the bearer of bad news, but the project has been inactive for a while.

lutzky commented 1 year ago

Damn ^_^

Oh well, I thought it'd be a useful thing. I've only encountered it as part of https://fasterthanli.me/series/building-a-rust-service-with-nix/part-6, so I figured I'd fix it as I go :shrug: