wagoodman / dive

A tool for exploring each layer in a docker image
MIT License
44.55k stars 1.69k forks source link

Layers pane doesn't scroll when navigating to layer below visible region #469

Open matt-winfield opened 10 months ago

matt-winfield commented 10 months ago

What happened: When viewing an image with more layers than can fit in the "layers" pane, when navigating down to a layer not visible, the pane does not scroll to show it. PageUp / PageDown keys also do not scroll the pane.

What you expected to happen: The pane should scroll to keep the currently selected layer visible

How to reproduce it (as minimally and precisely as possible): Open an image with enough layers to not fit into the pane Navigate down until you go beyond the visible layers.

Environment:

mark2185 commented 10 months ago

See comment.

I have something in progress, but it's not ready yet, hopefully soon.

dd84ai commented 10 months ago

Screenshot_20230820_181418 Layer Details is missing layer size. Which makes not accessible info beyond navigating list. Will be nice adding layer size into Layer Details :smile:

jamshid commented 10 months ago

TIP: This is a pretty limiting bug and older versions are not available on macOS brew. To workaround it try:

docker run -ti -v /var/run/docker.sock:/var/run/docker.sock wagoodman/dive:v0.10.0 IMAGE:TAG

Btw it doesn't show the full command line though of each RUN so that limits usefulness if you use --build-arg's.

mark2185 commented 10 months ago

Could you please give #473 a spin to see if it works well enough?

graffight commented 10 months ago

@mark2185 I've built your branch on Ubuntu 22.04 after having the scrolling bug with v0.11.0, and the bug still happens on your PR branch, built with golang 1.21 :(

perryrh0dan commented 9 months ago

Any update on this ? I have quiet a lot of layers in my image :(

moaimullet commented 9 months ago

I just submitted a fix that works for me #478

st-gr commented 1 month ago

@dd84ai: I added the size information to the layer details view (PR 522) I also added scrolling in the layers view see (PR 521)