search

wagoodman / dive

A tool for exploring each layer in a docker image
MIT License
44.55k stars 1.69k forks source link

Fix #475 - can't inspect `docker:23.0.1` with `podman` #476

Open abitrolly opened 9 months ago

abitrolly commented 9 months ago

Fix #475 - can't inspect docker:23.0.1 with podman

The problem was caused by net/url.Parse()

panic: parse "podman://docker:23.0.1": invalid port ":23.0.1" after host

https://go.dev/play/p/XM4j4RH6bA0

Testing the fix

✗ ./dive podman://docker:23.0.1
Image Source: podman://docker:23.0.1

✗ ./dive podman://docker:23.0.1 --source docker
Image Source: podman://docker:23.0.1

✗ ./dive docker:23.0.1 --source podman
Image Source: podman://docker:23.0.1