Adress issues raised by staticcheck and add it to workflow

wagslane / go-password-validator

Validate the Strength of a Password in Go

https://blog.boot.dev/open-source/how-to-validate-passwords/

MIT License

500 stars 40 forks source link

Adress issues raised by staticcheck and add it to workflow #4

Closed Jacalz closed 4 years ago

Jacalz commented 4 years ago

Staticcheck is a wonderful tool for performing static analysis of Go programs. This PR addresses all the issues (3 to be exact) that it mentioned and also adds it to the workflow for further checks in the future. I also updated the checkout action to v2 which most importantly has some performance work :)

Jacalz commented 4 years ago

I also added gosec for finding security issues in the code (there are none currently fyi) :)

wagslane commented 4 years ago

Love this contribution. Thank you. Just a couple comments before we merge