search

wagslane / go-rabbitmq

A wrapper of streadway/amqp that provides reconnection logic and sane defaults
https://blog.boot.dev/golang/connecting-to-rabbitmq-in-golang-easy/
MIT License
768 stars 125 forks source link

Remove Tracef logger requirement #123

Closed JarlMartinez closed 10 months ago

JarlMartinez commented 1 year ago

The current Logger interface in the package requires the Tracef method, however it is not used at all in code. I'm providing a custom zap logger to the consumer/publisher/connection options, and zap's doesn't implement such method either. I'd be ok adding the Tracef method locally just to satisfy the requirement, but it feels redundant. Is there any real reason to have such method requirement?

wagslane commented 1 year ago

Feel free to open a PR to have it removed!

abbasegbeyemi commented 1 year ago

Faced the same issue with zap. Just created a PR #138

wagslane commented 10 months ago

Thanks for the help, merged!