search

wagslane / go-rabbitmq

A wrapper of streadway/amqp that provides reconnection logic and sane defaults
https://blog.boot.dev/golang/connecting-to-rabbitmq-in-golang-easy/
MIT License
797 stars 129 forks source link

fix startNotifyFlowHandler (issue #13) #22

Closed pwli0755 closed 3 years ago

pwli0755 commented 3 years ago

fix issue #13 and add some comment

wagslane commented 3 years ago

Please fix tests!

pwli0755 commented 3 years ago 
go test ./...
?       github.com/wagslane/go-rabbitmq [no test files]
?       github.com/wagslane/go-rabbitmq/examples/consumer   [no test files]
?       github.com/wagslane/go-rabbitmq/examples/logger [no test files]
?       github.com/wagslane/go-rabbitmq/examples/publisher  [no test files]
go list -f '{{.Dir}}' ./... | grep -v /vendor/ | xargs -L1 gofmt -l
/home/runner/work/go-rabbitmq/go-rabbitmq/consume_options.go
test -z $(go list -f '{{.Dir}}' ./... | grep -v /vendor/ | xargs -L1 gofmt -l)
make: *** [Makefile:8: fmt] Error 1
Error: Process completed with exit code 2.

emm, it seems this error was triggered by consume_options.go

BTW, I'd like to suggest migrate to golangci-lint to check codebase.

wagslane commented 3 years ago

My bad! Just pull the latest changes and you should be good

pwli0755 commented 3 years ago

My bad! Just pull the latest changes and you should be good

done! pls have a check