search

wagslane / go-rabbitmq

A wrapper of streadway/amqp that provides reconnection logic and sane defaults
https://blog.boot.dev/golang/connecting-to-rabbitmq-in-golang-easy/
MIT License
772 stars 126 forks source link

This PR fixes the bug described in issue #34. #36

Closed rzajac closed 3 years ago

cyberbeast commented 3 years ago

@wagslane can this be merged, if it fixes #34 please?

wagslane commented 3 years ago

I'm surprised this works, considering it's already a pointer to the channel manager. Could you add a test that demonstrates what you're fixing?

cyberbeast commented 3 years ago

@wagslane I didn't fix anything. I am just encountering a similar data race possibly that @rzajac described and claims to fix in this PR.

wagslane commented 3 years ago

I'm closing this because I don't think it will fix the race in question. Adding more info to the issue