Declare Improvements - Githubissues

wagslane / go-rabbitmq

A wrapper of streadway/amqp that provides reconnection logic and sane defaults

https://blog.boot.dev/golang/connecting-to-rabbitmq-in-golang-easy/

MIT License

768 stars 125 forks source link

Declare Improvements #80

Closed h44z closed 2 years ago

h44z commented 2 years ago

This PR contains breaking changes to the API, but it has some huge improvements:

queue, exchange and binding declaration is now simplified and much clearer to use
declaration of queues, exchanges and bindings is also possible if the Publisher is used (#43 )
updated examples have been added too

wagslane commented 2 years ago

Thanks for the help!

Not gonna lie, this is a lotta code changes, so it might take a bit to get to reviewing this properly. It would help though it you maybe split this up a bit?

These 2 objectives would be easier to evaluate in separate PRs:

queue, exchange and binding declaration is now simplified and much clearer to use

declaration of queues, exchanges and bindings is also possible if the Publisher is used

h44z commented 2 years ago

i can try to split it up

h44z commented 2 years ago

I did the split =) new PRs are open