Closed ldmi3i closed 1 year ago
Agree, but this error will have some reason, and probably the old channel won't be closed. In this case, the channel can remain open and unused. So what do you think about just logging with 'warn' level? Added how it can be to PR.
Looks great to me!
Hello, probably here error handling missed.
It looks like even if it needs to be ignored here it would be good to add some logging in case of error. It is the wrong behavior of Close and the developer needs to know that something not good happened.