`c-sf-add-button--closed` classname should be `--close`

wagtail-deprecated / react-streamfield

Powerful field for inserting multiple blocks with nesting. (NO LONGER MAINTAINED - See Wagtail 2.13 Release Notes)

https://wagtail.github.io/react-streamfield/public/

35 stars 12 forks source link

`c-sf-add-button--closed` classname should be `--close` #10

Closed gasman closed 5 years ago

gasman commented 5 years ago

The --closed classname defined here:

https://github.com/wagtail/react-streamfield/blob/e775cd303323daabc6de824d23b1d74d6cb35354/src/scss/components/c-sf-add-button.scss#L36

would be better named --close, as it defines the style for a close button which appears when the panel is open.

Fixing this would mean that we can avoid the back-to-front logic of {% if state == 'open' %}c-sf-add-button--closed{% endif %} in https://github.com/wagtail/wagtail/pull/5476 :-)

BertrandBordage commented 5 years ago

Fixed by 307f1b6d39f6d900affc2c2c998ed113262a6cb3.