search

wagtail-deprecated / react-streamfield

Powerful field for inserting multiple blocks with nesting. (NO LONGER MAINTAINED - See Wagtail 2.13 Release Notes)
https://wagtail.github.io/react-streamfield/public/
35 stars 12 forks source link

:focus-within may drop some styles in IE 11 + Edge #8

Closed jonnyscholes closed 5 years ago

jonnyscholes commented 5 years ago

I happened across this article today:

https://catalin.red/fancy-new-selectors-can-break-your-css-rule/

Yet to have a chance to test this, but we do use :focus-within in a couple of places in c-sf-block.scss so should consider using JS instead or at least forcing it to be a separate selector so it only drops the :focus-within styles and not the :hover :focus too.

BertrandBordage commented 5 years ago

Fixed by https://github.com/wagtail/react-streamfield/commit/78df5639066a8c5a697eb5f109c5d26566f481cc.