search

wagtail-nest / wagtail-ab-testing

A/B testing for Wagtail
Other
23 stars 20 forks source link

Support wagtail42 #51

Closed nickmoreton closed 1 year ago

nickmoreton commented 1 year ago

This updates the package for Wagtail 4.2

Drops: support for Wagtail < 4.1

For completeness I have merged in the following previous work:

nickmoreton commented 1 year ago

Also when testing locally, I got this error: ValueError: Related model 'wagtailcore.pagerevision' cannot be resolved. Looks like one of the migration files needs updating.

Thanks this is now resolved in: https://github.com/wagtail-nest/wagtail-ab-testing/pull/51/commits/3c63ca4eb1b6709ff16e9f8fdd9fe738aae59841

nickmoreton commented 1 year ago

Thanks @victoriachan sorry for missing so much here. They should all be resolved now.

pymike00 commented 1 year ago

Thank you for this, @nickmoreton.

Much appreciated, gonna give it a try!

Do you actually work at Torchbox?

I wonder, with all due respect to the repo's owner and their time, why wasn't this PR even considered for merging?

Did they abandon the project?

Best, M.

mwesterhof commented 1 year ago

i'm with @pymike00 on this one, would love to know if there's been any changes regarding the maintenance of this project. We're currently investigating options for adding A/B testing support to some wagtail projects, but the lack of support for newer WT versions is quite a deal breaker for us.

Is this something either of you knows the answer to, @kaedroho or @victoriachan ?

nitinb99 commented 1 year ago

We are thrilled about incorporating the wagtail-ab-testing package into our project. However, since it doesn't currently support version 4.2, we are unable to use it. We appreciate the effort you have put into adding support for the 4.2 version. We hope that this pull request gets merged swiftly, and we eagerly await its integration. Thank you to @nickmoreton, @Stormheg and @victoriachan for your contributions.

Stormheg commented 1 year ago

Hey all,

I've spent a couple more hours on this and have come up with a revised PR (#52) that includes a fix for the PageRevision to Revision migration. This fix should work for new projects and projects already wagtail ab testing.

I don't think there are any other obstacles that prevent supporting Wagtail 4.1 and 4.2, hope my PR is merged soon 🤞

Stormheg commented 1 year ago

superseded by #52