search

wagtail-nest / wagtail-bakery

A set of helpers for baking your Django Wagtail site out as flat files.
MIT License
182 stars 40 forks source link

More decoding to utf8 to help python 3 #28

Closed stuaxo closed 6 years ago

stuaxo commented 6 years ago

Decode more data to utf8 so it works on python 3.x

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 73.709% when pulling edcb898aae55c9317af15f47c7bc890b53c35027 on stuaxo:patch-1 into 4c2979956a9601ffd25811314e90b31f713e60c6 on moorinteractive:master.

stuaxo commented 6 years ago

@robmoorman W00T now all unit tests but one pass from this simple fix :D

Any idea what the invalid request is https://travis-ci.org/moorinteractive/wagtail-bakery/jobs/338915003 ?

robmoorman commented 6 years ago

Thanks @stuaxo seems legit! (still have to diff into the single failing 400 test)

stuaxo commented 6 years ago

Glad to help :)

I have no idea what is up with the failing test, but it seems to only happen in django 111, so maybe something changed there from django 110 ?

I didn't have time to review the django release notes for 1.11 for clues.

I'm guessing it will fail in newer djangos too.