wagtail-nest / wagtail-personalisation

Rule-based personalisation for Wagtail CMS
http://wagxperience.io/
MIT License
120 stars 34 forks source link

Should date / time rules be timezone-aware? #130

Open tomdyson opened 7 years ago

tomdyson commented 7 years ago

The date and time rules are currently based on the server's clock:

https://github.com/LabD/wagtail-personalisation/blob/master/src/wagtail_personalisation/rules.py#L77

In some (most?) cases it will be more useful to base time rules on the user's clock, e.g. using the time rule to say 'Good morning' when the user is in Delhi and the server is in Cape Town.

In any case, the behaviour should be clarified for segment creators.

robmoorman commented 7 years ago

Nice found. Will fix it.