search

wagtail-nest / wagtail-whoosh

Search backend for Wagtail CMS using Whoosh engine.
24 stars 8 forks source link

Add more tests against recent Wagtail versions to ensure compatibility #14

Closed jjanssen closed 4 years ago

jjanssen commented 4 years ago

Right now when using wagtail-whoosh with a more recent Wagtail version it shows an warning / error concerning the used Wagtail version. For example:

ERROR: wagtail-whoosh 0.2.3 has requirement wagtail<=2.5,>=2.2, but you'll have wagtail 2.5.2 which is incompatible.

In the PR I added additional Python versions (3.7, 3.8) and Wagtail versions (2.7) to the testsuite.

Based on the Travis-run no errors show up with more recent Wagtail versions.

The current Tox and Travis setup is based upon the combinations which are defined in the overview of compatible Django and Python version as listed in the documentation.

I intentionally kept the reference to Wagtail 2.3 as I didn't want to make a bigger change than necessary for a possible release. Also because there are no code changes involved.

A next step would be leaving Wagtail 2.3 as is (and therefore dropping Python 3.4) as well as looking ahead into Wagtail 2.7 and Django 3.0 compatibility. But that would be more appropriate for a follow-up PR.

PS: Also added an .editorconfig as my editor was a bit confused with the indenting in the .yml file. So I have added the Editor configuration which is also used in the Wagtail repository.

michael-yin commented 4 years ago

@jjanssen

Thx for your PR.

I will check it later this week.😄

michael-yin commented 4 years ago

@jjanssen

I have merged your PR and thanks for your work!

It seems Coronavirus is spreading in EU, hope things get better soon.

Thx.

jjanssen commented 4 years ago

Thanks for merging and thanks for your thoughts. Currently working from home due to the situation but we'll manage :)