search

wagtail / Willow

A wrapper that combines the functionality of multiple Python image libraries into one API
https://willow.wagtail.org/
BSD 3-Clause "New" or "Revised" License
273 stars 53 forks source link

test_image.py: replace wrong unicdoe character #132

Closed stephanlachnit closed 10 months ago

stephanlachnit commented 10 months ago

The character U+0441 "с" was changed to the ASCII character U+0063 "c".

zerolab commented 10 months ago

@stephanlachnit that's a good catch. There is one other place this needs updating

~ ❯❯❯ ag "с" .
tests/test_image.py
185:        self.assertEqual(image.mime_type, "image/heiс")
220:            self.assertEqual(image.mime_type, "image/heiс")

willow/image.py
327:        return "image/heiс"

annoyingly the GitHub interface doesn't differentiate between them :/ The с is the cyrillic "s", rather than the latin c

stephanlachnit commented 10 months ago

There are a couple of other places where this needs updating

Good catch, I updated the PR.