search

wagtail / bakerydemo

Next generation Wagtail demo, born in Reykjavik
BSD 3-Clause "New" or "Revised" License
945 stars 538 forks source link

Updated project requirements #461

Closed jsma closed 9 months ago

jsma commented 10 months ago

Some of these were necessary for proper Django 4.2 support. Replaced linters with ruff and updated the pre-commit configuration to match upstream Wagtail for consistency.

bakerydemo does not appear to have its own test suite, but so far it appears to run correctly ;)

lb- commented 10 months ago

Just fired off the CI - it's failing so may need some tweaks.

Thanks for this @jsma - it will be nice to use the same linting tooling as Wagtail.

jsma commented 10 months ago

Apologies for missing that, I brought the Makefile in line with upstream for the relevant sections. 🤞it passes this time. Thanks!

jsma commented 10 months ago

This looks to be working now, and should address #421

jsma commented 10 months ago

Let me know your thoughts but perhaps #463 should be merged first and then I can rebase off of that to straighten out pre-commit-config.yaml. I also have WIP to introduce ruff format to match https://github.com/wagtail/wagtail/pull/11220 This PR intentionally kept ruff at the version currently used by Wagtail until my upstream PR is approved. If the upstream PR gets merged before this one, I could lump the ruff upgrade into this branch or just submit a follow up PR.

lb- commented 10 months ago

Good call @jsma - I did not realise there would be a large overlap with #463 but if this one does get merged first, I am happy to rebase.

thibaudcolas commented 9 months ago

Merged locally as I’m not allowed to push to this fork