search

wagtail / docker-wagtail-develop

75 stars 48 forks source link

`bakerydemo-settings-local.py.example` is invalid and not used #68

Closed jsma closed 12 months ago

jsma commented 12 months ago

This file was introduced in PR #55 (issue #54) because of upstream bakerydemo changes in https://github.com/wagtail/bakerydemo/pull/393. The problem is that the introduced example settings attempts to:

https://github.com/wagtail/docker-wagtail-develop/blob/9479945080321c9813597de4cd4817a2f319ebde/bakerydemo-settings-local.py.example#L1

This introduces a circular import because bakerydemo.settings.dev does this:

try:
    from .local import *  # noqa
except ImportError:
    pass

Is there any reason to keep bakerydemo-settings-local.py.example around or can it be removed and the build script be updated to simply copy from the actual bakerydemo/settings/local.py.example (which is currently empty)?

https://github.com/wagtail/docker-wagtail-develop/blob/9479945080321c9813597de4cd4817a2f319ebde/setup.sh#L37-L41