search

wagtail / guide

A website to teach Wagtail CMS to content editors, moderators and administrators.
https://guide.wagtail.org
BSD 3-Clause "New" or "Revised" License
32 stars 26 forks source link

Set height for alert icon #315

Closed mgax closed 1 year ago

mgax commented 1 year ago

Fixes https://github.com/wagtail/guide/issues/281

Before

Screenshot 2023-06-07 at 18 33 28

After

Screenshot 2023-06-07 at 18 33 02
lb- commented 1 year ago

@thibaudcolas or @RealOrangeOne do you mind taking a look at this PR.

RealOrangeOne commented 1 year ago

As a code change, I think this looks fine. However CI suggests otherwise. I've also not tested the change locally.

lb- commented 1 year ago

@mgax can you review the CI error - add a comment when it's ready for another run.

mgax commented 1 year ago

@lb- thanks for unblocking this. I've pushed a fix for the linting error.

lb- commented 1 year ago

Merged in, thanks @mgax !

lb- commented 1 year ago

Have added you to https://guide.wagtail.org/en-latest/about/#website-build-contributors - thanks heaps

mgax commented 1 year ago

Thanks a lot @lb-!